linux-kernel - Re: [PATCH] lib/test_kmod: Potential double free in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190122194716.GC11489@garbanzo.do-not-panic.com>
Date:   Tue, 22 Jan 2019 11:47:17 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>, akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] lib/test_kmod: Potential double free in error handling

On Mon, Jan 21, 2019 at 05:00:11PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug so we set "config->test_driver" to NULL
> twice instead of setting "config->test_fs".  Smatch complains that it
> leads to a double free:
> 
> lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_fs' double freed
> 
> Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks!

Acked-by: Luis Chamberlain <mcgrof@...nel.org>

 Luis