linux-kernel - Re: [PATCH] lightnvm: pblk: use vfree to free metadata on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b39d129-7db0-d2d9-4178-f2ac0009ce04@lightnvm.io>
Date:   Tue, 22 Jan 2019 20:48:50 +0100
From:   Matias Bjørling <mb@...htnvm.io>
To:     hans@...tronix.com
Cc:     javier@...igon.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Hans Holmberg <hans.holmberg@...xlabs.com>
Subject: Re: [PATCH] lightnvm: pblk: use vfree to free metadata on error path

On 1/22/19 11:17 AM, hans@...tronix.com wrote:
> From: Hans Holmberg <hans.holmberg@...xlabs.com>
> 
> As chunk metadata is allocated using vmalloc, we need to free it
> using vfree.
> 
> Fixes: 090ee26fd512 ("lightnvm: use internal allocation for chunk log page")
> Signed-off-by: Hans Holmberg <hans.holmberg@...xlabs.com>
> ---
>   drivers/lightnvm/pblk-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 1ff165351180..1b5ff51faa63 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -141,7 +141,7 @@ struct nvm_chk_meta *pblk_get_chunk_meta(struct pblk *pblk)
>   
>   	ret = nvm_get_chunk_meta(dev, ppa, geo->all_chunks, meta);
>   	if (ret) {
> -		kfree(meta);
> +		vfree(meta);
>   		return ERR_PTR(-EIO);
>   	}
>   
> 

Thanks Hans. Applied for 5.1.