linux-kernel - Re: [PATCH] brcm80211: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530d2424-d679-c81a-9d11-02b2d7631bea@broadcom.com>
Date:   Tue, 22 Jan 2019 21:07:48 +0100
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Wright Feng <wright.feng@...ress.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com
Subject: Re: [PATCH] brcm80211: no need to check return value of
 debugfs_create functions

The prefix should be 'brcmsmac'.

On 1/22/2019 4:21 PM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.

I could argue that if above is true it would be better to make the 
debugfs function return void, but I won't ;-p

In start_creating() the parent dentry is indeed checked for IS_ERR() so...

Acked-by: Arend van Spriel

> Cc: Arend van Spriel <arend.vanspriel@...adcom.com>
> Cc: Franky Lin <franky.lin@...adcom.com>
> Cc: Hante Meuleman <hante.meuleman@...adcom.com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@...ress.com>
> Cc: Wright Feng <wright.feng@...ress.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: linux-wireless@...r.kernel.org
> Cc: brcm80211-dev-list.pdl@...adcom.com
> Cc: brcm80211-dev-list@...ress.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>   .../broadcom/brcm80211/brcmsmac/debug.c       | 26 +++----------------
>   .../broadcom/brcm80211/brcmsmac/debug.h       |  2 +-
>   2 files changed, 5 insertions(+), 23 deletions(-)