linux-kernel - Re: [PATCH] brcm80211: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190122204340.GA30535@kroah.com>
Date:   Tue, 22 Jan 2019 21:43:40 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arend Van Spriel <arend.vanspriel@...adcom.com>
Cc:     linux-kernel@...r.kernel.org, Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Wright Feng <wright.feng@...ress.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com
Subject: Re: [PATCH] brcm80211: no need to check return value of
 debugfs_create functions

On Tue, Jan 22, 2019 at 09:07:48PM +0100, Arend Van Spriel wrote:
> The prefix should be 'brcmsmac'.
> 
> On 1/22/2019 4:21 PM, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> 
> I could argue that if above is true it would be better to make the debugfs
> function return void, but I won't ;-p

I would really want to do that, but sometimes you need that return value
to pass to other debugfs functions :(

> In start_creating() the parent dentry is indeed checked for IS_ERR() so...
> 
> Acked-by: Arend van Spriel

thanks for the review!

greg k-h