linux-kernel - Re: [PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190122215104.GI26416@windriver.com>
Date:   Tue, 22 Jan 2019 16:51:05 -0500
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     Andreas Färber <afaerber@...e.de>,
        Sven Van Asbroeck <thesven73@...il.com>, <svendev@...x.com>,
        <robh+dt@...nel.org>, <linus.walleij@...aro.org>,
        <lee.jones@...aro.org>, <mark.rutland@....com>,
        <treding@...dia.com>, <david@...hnology.com>, <noralf@...nnes.org>,
        <johan@...nel.org>, <monstr@...str.eu>, <michal.vokac@...ft.com>,
        <arnd@...db.de>, <john.garry@...wei.com>,
        <geert+renesas@...der.be>, <robin.murphy@....com>,
        <sebastien.bourdelin@...oirfairelinux.com>, <icenowy@...c.io>,
        <stuyoder@...il.com>, <maxime.ripard@...tlin.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.

[Re: [PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.] On 22/01/2019 (Tue 19:52) Greg KH wrote:

> On Tue, Jan 22, 2019 at 06:12:31PM +0100, Andreas Färber wrote:
> > Am 22.01.19 um 17:56 schrieb Paul Gortmaker:
> > > [[PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.] On 22/01/2019 (Tue 10:21) Sven Van Asbroeck wrote:

[...]

> > >> diff --git a/drivers/fieldbus/Kconfig b/drivers/fieldbus/Kconfig
> > >> new file mode 100644
> > >> index 000000000000..5c2bef950d04
> > >> --- /dev/null
> > >> +++ b/drivers/fieldbus/Kconfig
> > >> @@ -0,0 +1,19 @@
> > >> +menuconfig FIELDBUS_DEV
> > >> +	bool "Fieldbus Device Support"
> > > 
> > > OK, so the core support is NOT tristate, ie not modular,
> > 
> > Is that intentional though, and if so, why?
> > 
> > If possible, I would much rather see it changed to tristate and leave
> > all the metadata below.

[...]

> And I thought when I made the comment about this code being a module,
> that would be the change, not this one forcing it not to be :(

Apologies Greg, I didn't see that earlier comment.

Conversion to tristate is of course perfectly fine as well; I'm just
against the inconsistency and addition of unused code.  But tristate
solves both, and I usually mention that (but not this time...<sigh>)

I just default to suggesting removing the unused stuff, since it doesn't
change the runtime or implicitly expand the use case beyond what the
original author(s) intended.  Many times (just as here with fieldbus)
I just don't know enough about it to say whether modular has a use case.

Paul.
--

> 
> thanks,
> 
> greg k-h