linux-kernel - Re: [PATCH RFC 05/24] userfaultfd: wp: add helper for writeprotect check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190122083146.GD14907@xz-x1>
Date:   Tue, 22 Jan 2019 16:31:46 +0800
From:   Peter Xu <peterx@...hat.com>
To:     Mike Rapoport <rppt@...ux.ibm.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Hugh Dickins <hughd@...gle.com>,
        Maya Gokhale <gokhale2@...l.gov>,
        Jerome Glisse <jglisse@...hat.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Martin Cracauer <cracauer@...s.org>,
        Denis Plotnikov <dplotnikov@...tuozzo.com>,
        Shaohua Li <shli@...com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Pavel Emelyanov <xemul@...allels.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Marty McFadden <mcfadden8@...l.gov>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Mel Gorman <mgorman@...e.de>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>,
        Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH RFC 05/24] userfaultfd: wp: add helper for writeprotect
 check

On Mon, Jan 21, 2019 at 12:23:12PM +0200, Mike Rapoport wrote:
> On Mon, Jan 21, 2019 at 03:57:03PM +0800, Peter Xu wrote:
> > From: Shaohua Li <shli@...com>
> > 
> > add helper for writeprotect check. Will use it later.
> 
> I'd merge this with the commit that actually uses this helper.

Hi, Mike,

Yeah actually that's what I'd prefer for most of the time.  But I'm
trying to avoid doing that because I wanted to keep the credit of the
original authors, not only for this single patch, but also for the
whole series.  Meanwhile, since this work has been there for quite a
few years (starting from 2015), IMHO keeping the old patches mostly
untouched at least in the RFC stage might also help the reviewers if
they have read or prior knowledge of the previous work.

And if the patch cannot even stand on itself (this one can; it only
introduces new functions) I'll do the merge no matter what.

Please correct me if this is not the good way to do.

Thanks!

>  
> > Cc: Andrea Arcangeli <aarcange@...hat.com>
> > Cc: Pavel Emelyanov <xemul@...allels.com>
> > Cc: Rik van Riel <riel@...hat.com>
> > Cc: Kirill A. Shutemov <kirill@...temov.name>
> > Cc: Mel Gorman <mgorman@...e.de>
> > Cc: Hugh Dickins <hughd@...gle.com>
> > Cc: Johannes Weiner <hannes@...xchg.org>
> > Signed-off-by: Shaohua Li <shli@...com>
> > Signed-off-by: Andrea Arcangeli <aarcange@...hat.com>
> > Signed-off-by: Peter Xu <peterx@...hat.com>
> > ---
> >  include/linux/userfaultfd_k.h | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h
> > index 37c9eba75c98..38f748e7186e 100644
> > --- a/include/linux/userfaultfd_k.h
> > +++ b/include/linux/userfaultfd_k.h
> > @@ -50,6 +50,11 @@ static inline bool userfaultfd_missing(struct vm_area_struct *vma)
> >  	return vma->vm_flags & VM_UFFD_MISSING;
> >  }
> > 
> > +static inline bool userfaultfd_wp(struct vm_area_struct *vma)
> > +{
> > +	return vma->vm_flags & VM_UFFD_WP;
> > +}
> > +
> >  static inline bool userfaultfd_armed(struct vm_area_struct *vma)
> >  {
> >  	return vma->vm_flags & (VM_UFFD_MISSING | VM_UFFD_WP);
> > @@ -94,6 +99,11 @@ static inline bool userfaultfd_missing(struct vm_area_struct *vma)
> >  	return false;
> >  }
> > 
> > +static inline bool userfaultfd_wp(struct vm_area_struct *vma)
> > +{
> > +	return false;
> > +}
> > +
> >  static inline bool userfaultfd_armed(struct vm_area_struct *vma)
> >  {
> >  	return false;
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Sincerely yours,
> Mike.
> 

Regards,

-- 
Peter Xu