linux-kernel - Re: [PATCH] pinctrl: remove unused 'pinconf-config' debugfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Jan 2019 17:14:18 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vladimir Zapolskiy <vz@...ia.com>
Cc:     kbuild-all@...org, Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Laurent Meunier <laurent.meunier@...com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] pinctrl: remove unused 'pinconf-config' debugfs interface

Hi Vladimir,

I love your patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v5.0-rc2 next-20190116]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Zapolskiy/pinctrl-remove-unused-pinconf-config-debugfs-interface/20190122-044655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: i386-randconfig-x0-01221345 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/pinctrl/cirrus/pinctrl-madera-core.c:25:0:
>> drivers/pinctrl/cirrus/../pinctrl-utils.h:36:8: warning: 'enum pinctrl_map_type' declared inside parameter list
      enum pinctrl_map_type type);
           ^
>> drivers/pinctrl/cirrus/../pinctrl-utils.h:36:8: warning: its scope is only this definition or declaration, which is probably not what you want
   drivers/pinctrl/cirrus/pinctrl-madera-core.c: In function 'madera_pin_probe':
>> drivers/pinctrl/cirrus/pinctrl-madera-core.c:1044:9: error: implicit declaration of function 'pinctrl_register_mappings' [-Werror=implicit-function-declaration]
      ret = pinctrl_register_mappings(pdata->gpio_configs,
            ^
   cc1: some warnings being treated as errors

vim +36 drivers/pinctrl/cirrus/../pinctrl-utils.h

1eb207a9e Laxman Dewangan 2013-08-06  24  
1eb207a9e Laxman Dewangan 2013-08-06  25  int pinctrl_utils_reserve_map(struct pinctrl_dev *pctldev,
1eb207a9e Laxman Dewangan 2013-08-06  26  		struct pinctrl_map **map, unsigned *reserved_maps,
1eb207a9e Laxman Dewangan 2013-08-06  27  		unsigned *num_maps, unsigned reserve);
1eb207a9e Laxman Dewangan 2013-08-06  28  int pinctrl_utils_add_map_mux(struct pinctrl_dev *pctldev,
1eb207a9e Laxman Dewangan 2013-08-06  29  		struct pinctrl_map **map, unsigned *reserved_maps,
1eb207a9e Laxman Dewangan 2013-08-06  30  		unsigned *num_maps, const char *group,
1eb207a9e Laxman Dewangan 2013-08-06  31  		const char *function);
1eb207a9e Laxman Dewangan 2013-08-06  32  int pinctrl_utils_add_map_configs(struct pinctrl_dev *pctldev,
1eb207a9e Laxman Dewangan 2013-08-06  33  		struct pinctrl_map **map, unsigned *reserved_maps,
1eb207a9e Laxman Dewangan 2013-08-06  34  		unsigned *num_maps, const char *group,
1eb207a9e Laxman Dewangan 2013-08-06  35  		unsigned long *configs, unsigned num_configs,
1eb207a9e Laxman Dewangan 2013-08-06 @36  		enum pinctrl_map_type type);
1eb207a9e Laxman Dewangan 2013-08-06  37  int pinctrl_utils_add_config(struct pinctrl_dev *pctldev,
1eb207a9e Laxman Dewangan 2013-08-06  38  		unsigned long **configs, unsigned *num_configs,
1eb207a9e Laxman Dewangan 2013-08-06  39  		unsigned long config);
d32f7fd3b Irina Tirdea    2016-03-31  40  void pinctrl_utils_free_map(struct pinctrl_dev *pctldev,
1eb207a9e Laxman Dewangan 2013-08-06  41  		struct pinctrl_map *map, unsigned num_maps);
1eb207a9e Laxman Dewangan 2013-08-06  42  

:::::: The code at line 36 was first introduced by commit
:::::: 1eb207a9ecaafb980704d8bc055a9a0269f62f8e pinctrl: add utility functions for add map/configs

:::::: TO: Laxman Dewangan <ldewangan@...dia.com>
:::::: CC: Linus Walleij <linus.walleij@...aro.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (33502 bytes)