linux-kernel - Re: [PATCH V2] pwm: Add MediaTek MT8183 display PWM driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Jan 2019 10:16:03 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Jitao Shi <jitao.shi@...iatek.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
        Mark Rutland <mark.rutland@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Kumar Gala <galak@...eaurora.org>, linux-pwm@...r.kernel.org,
        David Airlie <airlied@...ux.ie>,
        Matthias Brugger <matthias.bgg@...il.com>, stonea168@....com,
        dri-devel@...ts.freedesktop.org,
        Andy Yan <andy.yan@...k-chips.com>,
        Ajay Kumar <ajaykumar.rs@...sung.com>,
        Vincent Palatin <vpalatin@...omium.org>,
        cawa.cheng@...iatek.com, bibby.hsieh@...iatek.com,
        ck.hu@...iatek.com, Russell King <rmk+kernel@....linux.org.uk>,
        Thierry Reding <treding@...dia.com>,
        devicetree@...r.kernel.org, Philipp Zabel <p.zabel@...gutronix.de>,
        Inki Dae <inki.dae@...sung.com>,
        linux-mediatek@...ts.infradead.org, yingjoe.chen@...iatek.com,
        eddie.huang@...iatek.com, linux-arm-kernel@...ts.infradead.org,
        Rahul Sharma <rahul.sharma@...sung.com>,
        srv_heupstream@...iatek.com, linux-kernel@...r.kernel.org,
        Sascha Hauer <kernel@...gutronix.de>,
        Sean Paul <seanpaul@...omium.org>
Subject: Re: [PATCH V2] pwm: Add MediaTek MT8183 display PWM driver support

On Tue, Jan 22, 2019 at 05:02:43PM +0800, Jitao Shi wrote:
> Use the mtk_pwm_data struction to define different registers
> and add MT8183 specific register operations, such as MT8183
> doesn't have commit register, needs to disable double buffer
> before writing register, and needs to select commit mode
> and use PWM_PERIOD/PWM_HIGH_WIDTH.
> 
> Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>

There is no difference compared to (implicit) v1 sent a few minutes
earlier, right? There was another patch sent with the same Subject last
week, so I assume the mail from today without "v2" in the Subject was a
mistake?

> ---
Adding a paragraph below the tripple dash that points out what was
changed compared to the previous submission is a good idea to help
reviewers to more easily see what was changed. I guess you only adapted
the commit log as a reaction to Matthias Burgger's review?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |