linux-kernel - Re: [PATCH] nvram: annotate implicit fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Jan 2019 10:23:01 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvram: annotate implicit fall through

On Mon, Jan 14, 2019 at 09:44:15PM +0100, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
> 
> This commit remove the following warning:
> 
>   drivers/char/generic_nvram.c:83:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/char/generic_nvram.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/generic_nvram.c b/drivers/char/generic_nvram.c
> index ff5394f47587..53123c110f7b 100644
> --- a/drivers/char/generic_nvram.c
> +++ b/drivers/char/generic_nvram.c
> @@ -81,6 +81,7 @@ static int nvram_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  #ifdef CONFIG_PPC_PMAC
>  	case OBSOLETE_PMAC_NVRAM_GET_OFFSET:
>  		printk(KERN_WARNING "nvram: Using obsolete PMAC_NVRAM_GET_OFFSET ioctl\n");
> +		/* fall through */
>  	case IOC_NVRAM_GET_OFFSET: {
>  		int part, offset;
>  

This file is now gone from my tree, sorry.

greg k-h