linux-kernel - Re: [PATCH 5/6] tty: serial: qcom_geni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Jan 2019 12:23:30 +0530
From:   alokc@...eaurora.org
To:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, Mark Brown <broonie@...nel.org>
Cc:     andy.gross@...aro.org, david.brown@...aro.org,
        georgi.djakov@...aro.org, dianders@...omium.org,
        swboyd@...omium.org, bjorn.andersson@...aro.org,
        linux-serial-owner@...r.kernel.org
Subject: Re: [PATCH 5/6] tty: serial: qcom_geni_serial: Add interconnect
 support

+Mark Brown

On 2019-01-22 12:03, Alok Chauhan wrote:
> Get the interconnect paths for Uart based Serial Engine device
> and vote accordingly based on maximum supported Uart frequency.
> 
> Signed-off-by: Alok Chauhan <alokc@...eaurora.org>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 27 ++++++++++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c
> b/drivers/tty/serial/qcom_geni_serial.c
> index a72d6d9..e2ea499 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -19,6 +19,7 @@
>  #include <linux/slab.h>
>  #include <linux/tty.h>
>  #include <linux/tty_flip.h>
> +#include <linux/interconnect.h>
> 
>  /* UART specific GENI registers */
>  #define SE_UART_LOOPBACK_CFG		0x22c
> @@ -1348,6 +1349,22 @@ static int qcom_geni_serial_probe(struct
> platform_device *pdev)
>  		return ret;
>  	}
> 
> +	/* Set the bus quota to a reasonable value */
> +	port->se.avg_bw = console ? Bps_to_icc(1000) : Bps_to_icc(2500);
> +	port->se.peak_bw = Bps_to_icc(76800000);
> +	ret = geni_interconnect_init(&port->se);
> +	if (ret) {
> +		dev_err(&pdev->dev, "interconnect_init failed %d\n", ret);
> +		return ret;
> +	}
> +
> +	/*
> +	 * Vote for interconnect path early. This has to move as part of
> +	 * Runtime PM APIs when implemented for better control betwen
> +	 * console and non-console usecases
> +	 */
> +	geni_icc_update_bw(&port->se, true);
> +
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!res)
>  		return -EINVAL;
> @@ -1385,8 +1402,15 @@ static int __maybe_unused
> qcom_geni_serial_sys_suspend(struct device *dev)
>  {
>  	struct qcom_geni_serial_port *port = dev_get_drvdata(dev);
>  	struct uart_port *uport = &port->uport;
> +	int ret;
> +
> +	ret = uart_suspend_port(uport->private_data, uport);
> +	if (ret)
> +		return ret;
> +
> +	geni_icc_update_bw(&port->se, false);
> 
> -	return uart_suspend_port(uport->private_data, uport);
> +	return 0;
>  }
> 
>  static int __maybe_unused qcom_geni_serial_sys_resume(struct device 
> *dev)
> @@ -1394,6 +1418,7 @@ static int __maybe_unused
> qcom_geni_serial_sys_resume(struct device *dev)
>  	struct qcom_geni_serial_port *port = dev_get_drvdata(dev);
>  	struct uart_port *uport = &port->uport;
> 
> +	geni_icc_update_bw(&port->se, true);
>  	return uart_resume_port(uport->private_data, uport);
>  }

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,a Linux Foundation Collaborative Project