linux-kernel - Re: [PATCH] qspinlock: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190123092245.GB14010@kroah.com>
Date:   Wed, 23 Jan 2019 10:22:45 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Will Deacon <will.deacon@....com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] qspinlock: no need to check return value of
 debugfs_create functions

On Wed, Jan 23, 2019 at 09:10:18AM +0000, Will Deacon wrote:
> On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> > 
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: Will Deacon <will.deacon@....com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  kernel/locking/qspinlock_stat.h | 18 ++++--------------
> >  1 file changed, 4 insertions(+), 14 deletions(-)
> 
> Curious, but are you planning to make these functions return void after
> you've modified all of the callers?

I wish, but I can't, as those values are needed for some other debugfs
calls.

thanks,

greg k-h