linux-kernel - Re: [RFC/RFT PATCH 11/15] crypto: testmgr - convert skcipher testing to use testvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190124131414.GA13624@Red>
Date:   Thu, 24 Jan 2019 14:14:14 +0100
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     Eric Biggers <ebiggers@...nel.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Jason A . Donenfeld" <Jason@...c4.com>
Subject: Re: [RFC/RFT PATCH 11/15] crypto: testmgr - convert skcipher testing
 to use testvec_configs

On Thu, Jan 24, 2019 at 01:36:23PM +0100, Ard Biesheuvel wrote:
> On Wed, 23 Jan 2019 at 23:53, Eric Biggers <ebiggers@...nel.org> wrote:
> >
> > From: Eric Biggers <ebiggers@...gle.com>
> >
> > Convert alg_test_skcipher() to use the new test framework, adding a list
> > of testvec_configs to test by default.  When the extra self-tests are
> > enabled, randomly generated testvec_configs are tested as well.
> >
> > This improves skcipher test coverage mainly because now all algorithms
> > have a variety of data layouts tested, whereas before each algorithm was
> > responsible for declaring its own chunked test cases which were often
> > missing or provided poor test coverage.  The new code also tests both
> > the MAY_SLEEP and !MAY_SLEEP cases, different IV alignments, and buffers
> > that cross pages.
> >
> > This has already found a bug in the arm64 ctr-aes-neonbs algorithm.
> > It would have easily found many past bugs.
> >
> > I removed the skcipher chunked test vectors that were the same as
> > non-chunked ones, but left the ones that were unique.
> >
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> 
> This patch does not apply after applying 1..10 onto cryptodev/master
> 
> Do you have a tree somewhere?

Hello

I got the same with next.
You need to apply "crypto: clarify name of WEAK_KEY request flag" from his repo:
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git branch testmgr-improvements

Regards