linux-kernel - Re: [PATCH v1] : Switch to use new generic UUID API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6D748F08-F9F9-4DFB-84DF-63E97C691013@javigon.com>
Date:   Thu, 24 Jan 2019 14:17:37 +0100
From:   Javier González <javier@...igon.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Christoph Hellwig <hch@....de>,
        Matias Bjørling <mb@...htnvm.io>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] : Switch to use new generic UUID API


> On 24 Jan 2019, at 13.16, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> On Mon, Jan 21, 2019 at 09:47:32AM +0100, Christoph Hellwig wrote:
>> On Thu, Jan 10, 2019 at 04:30:51PM +0200, Andy Shevchenko wrote:
>>> There are new types and helpers that are supposed to be used in new code.
>>> 
>>> As a preparation to get rid of legacy types and API functions do
>>> the conversion here.
>> 
>> This seems to miss a "lightnvm" in the subject line.
>> 
>>> static inline void pblk_setup_uuid(struct pblk *pblk)
>>> {
>>> +	guid_gen((guid_t *)&pblk->instance_uuid);
>>> }
>> 
>> I think we can just kill this wrapper.
>> 
>> But more importantly the instance_uuid fied, and the header.uuid one
>> it is copied from should be turned into an actual guid_t, the memcpys
>> and memcmps should also be replaced with the proper UUID API.
> 
> header.uuid is defined using __u8 type, I'm not sure we can use guid_t there.
> 

We can turn it into a guid_t and bump the minor version.

Javier

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)