[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f9b58195-9345-ab13-87b2-2c261aa89b58@aquantia.com>
Date: Thu, 24 Jan 2019 14:58:45 +0000
From: Igor Russkikh <Igor.Russkikh@...antia.com>
To: Antoine Tenart <antoine.tenart@...tlin.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"sd@...asysnail.net" <sd@...asysnail.net>,
"andrew@...n.ch" <andrew@...n.ch>,
"f.fainelli@...il.com" <f.fainelli@...il.com>,
"hkallweit1@...il.com" <hkallweit1@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
"alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
"quentin.schulz@...tlin.com" <quentin.schulz@...tlin.com>,
"allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>
Subject: Re: [PATCH net-next 06/10] net: introduce a net_device_ops macsec
helper
Hi Antoine,
Its great to see macsec hw offload infrastructure happening!
> @@ -1441,6 +1445,10 @@ struct net_device_ops {
> u32 flags);
> int (*ndo_xsk_async_xmit)(struct net_device *dev,
> u32 queue_id);
> +#ifdef CONFIG_MACSEC
> + int (*ndo_macsec)(struct net_device *dev,
> + struct netdev_macsec *macsec);
> +#endif
> };
Most of ndo's are named by action verbs. This ndo is abit misleading, reader
may have difficulties understanding what
+ if (phydev->drv->macsec)
+ ret = phydev->drv->macsec(phydev, macsec);
is actually doing.
May be it'd be better renaming to at least ndo_do_macsec(), or ndo_setup_macsec()
?
Similar comment is for
+struct netdev_macsec {
It reads like a macsec device context, but it is a macsec configuration command.
Regards,
Igor
Powered by blists - more mailing lists