linux-kernel - Re: [PATCH v6 07/13] KVM: s390: introduce struct kvm_s390_gisa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a9f57ea6-4f87-3af0-46c9-695708f98649@linux.ibm.com>
Date:   Thu, 24 Jan 2019 16:24:28 +0100
From:   Michael Mueller <mimu@...ux.ibm.com>
To:     Cornelia Huck <cohuck@...hat.com>
Cc:     KVM Mailing List <kvm@...r.kernel.org>,
        Linux-S390 Mailing List <linux-s390@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Halil Pasic <pasic@...ux.ibm.com>,
        Pierre Morel <pmorel@...ux.ibm.com>
Subject: Re: [PATCH v6 07/13] KVM: s390: introduce struct
 kvm_s390_gisa_interrupt



On 24.01.19 16:06, Cornelia Huck wrote:
> On Thu, 24 Jan 2019 13:59:33 +0100
> Michael Mueller <mimu@...ux.ibm.com> wrote:
> 
>> Use this struct analog to the kvm interruption structs
>> for kvm emulated floating and local interruptions.
> 
> I guess that makes sense.
> 
>> Further fields will be added with this series as
>> required.
> 
> A reference to "this series" will look a bit strange if you look at the
> committed patch later. What about:
> 
> "GIB handling will add further fields to this structure as required."

Yes, that reads pretty well. I will replace the sentence.

> 
> ?
> 
>>
>> Signed-off-by: Michael Mueller <mimu@...ux.ibm.com>
>> ---
>>   arch/s390/include/asm/kvm_host.h |  6 ++++-
>>   arch/s390/kvm/interrupt.c        | 52 +++++++++++++++++++++++-----------------
>>   arch/s390/kvm/kvm-s390.c         |  2 +-
>>   3 files changed, 36 insertions(+), 24 deletions(-)
> 
> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
>