linux-kernel - Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3DC0DB52-E3B0-42F3-BD4D-913FD77EDFBB@holtmann.org>
Date:   Fri, 25 Jan 2019 08:56:46 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in
 l2cap_config_rsp

Hi Mathieu,

> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
> 
> This commit removes the following warning:
> 
>  net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Cc: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
> net/bluetooth/l2cap_core.c | 1 +
> 1 file changed, 1 insertion(+)

the patches don’t apply cleanly against bluetooth-next tree. Please fix it up and resend.

Regards

Marcel