linux-kernel - Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7wUswPXAbsrNOUDUN4GMof7oV8pbxfcWLxXXZdx7DnBd4U5w@mail.gmail.com>
Date:   Fri, 25 Jan 2019 09:08:41 +0100
From:   Mathieu Malaterre <malat@...ian.org>
To:     Marcel Holtmann <marcel@...tmann.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp

On Fri, Jan 25, 2019 at 8:56 AM Marcel Holtmann <marcel@...tmann.org> wrote:
>
> Hi Mathieu,
>
> > There is a plan to build the kernel with -Wimplicit-fallthrough and
> > this place in the code produced a warning (W=1).
> >
> > This commit removes the following warning:
> >
> >  net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >
> > Cc: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> > Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> > ---
> > net/bluetooth/l2cap_core.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> the patches don’t apply cleanly against bluetooth-next tree. Please fix it up and resend.

Never mind, both warnings are already fixed by:

6317950c1b9c Bluetooth: Mark expected switch fall-throughs

Sorry for the noise

> Regards
>
> Marcel
>