linux-kernel - Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+U=DsqG6PKs1Off9QP_3_q+c5=uzRypHCs+O6iur=NC5QdDdQ@mail.gmail.com>
Date:   Fri, 25 Jan 2019 10:19:54 +0200
From:   Alexandru Ardelean <ardeleanalex@...il.com>
To:     Rodrigo Ribeiro <rodrigorsdc@...il.com>
Cc:     lars@...afoo.de, Michael.Hennerich@...log.com,
        Jonathan Cameron <jic23@...nel.org>, knaack.h@....de,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        kernel-usp@...glegroups.com, Rafael Tsuha <rafael.tsuha@....br>
Subject: Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@...il.com> wrote:
>
> Remove the checkpatch.pl check:
>
> CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?

Hey,

A bit curios about this one.
Are you using this chip/driver ?

Thing is: the part is nearing EOL, and it could be an idea to be
marked for removal (since it's still in staging).
But if there are users for this driver, it could be left around for a while.

Thanks
Alex

>
> Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@...il.com>
> Signed-off-by: Rafael Tsuha <rafael.tsuha@....br>
> ---
> This macro is not used anywhere. Should we just correct the
> spelling or remove the macro?
>
>  drivers/staging/iio/cdc/ad7152.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index 25f51db..c9da6d4 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -35,7 +35,7 @@
>  #define AD7152_REG_CH2_GAIN_HIGH       12
>  #define AD7152_REG_CH2_SETUP           14
>  #define AD7152_REG_CFG                 15
> -#define AD7152_REG_RESEVERD            16
> +#define AD7152_REG_RESERVED            16
>  #define AD7152_REG_CAPDAC_POS          17
>  #define AD7152_REG_CAPDAC_NEG          18
>  #define AD7152_REG_CFG2                        26
> --
> 2.7.4
>