[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOeBkLogWyxbB3ZNwZh9=6xVUKxmT1YGZQseAx4uo7a4u+M+gw@mail.gmail.com>
Date: Fri, 25 Jan 2019 21:46:58 -0200
From: Rodrigo Ribeiro <rodrigorsdc@...il.com>
To: Alexandru Ardelean <ardeleanalex@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com,
Jonathan Cameron <jic23@...nel.org>, knaack.h@....de,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
kernel-usp@...glegroups.com, Rafael Tsuha <rafael.tsuha@....br>
Subject: Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED
Em sex, 25 de jan de 2019 às 06:20, Alexandru Ardelean
<ardeleanalex@...il.com> escreveu:
>
> On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@...il.com> wrote:
> >
> > Remove the checkpatch.pl check:
> >
> > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?
>
> Hey,
Hi,
Thanks for answering.
> A bit curios about this one.
> Are you using this chip/driver ?
No, I am just a student at USP (University of São Paulo) starting in Linux
Kernel and a new member of the USP Linux Kernel group that has contributed
for a few months.
> Thing is: the part is nearing EOL, and it could be an idea to be
> marked for removal (since it's still in staging).
> But if there are users for this driver, it could be left around for a while.
This is my first patch in Linux Kernel, but if the driver will be removed, I
can send a patch for another driver. Is there any driver that I can
fix a style warning?
Thanks
Em sex, 25 de jan de 2019 às 06:20, Alexandru Ardelean
<ardeleanalex@...il.com> escreveu:
>
> On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@...il.com> wrote:
> >
> > Remove the checkpatch.pl check:
> >
> > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?
>
> Hey,
>
> A bit curios about this one.
> Are you using this chip/driver ?
>
> Thing is: the part is nearing EOL, and it could be an idea to be
> marked for removal (since it's still in staging).
> But if there are users for this driver, it could be left around for a while.
>
> Thanks
> Alex
>
> >
> > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@...il.com>
> > Signed-off-by: Rafael Tsuha <rafael.tsuha@....br>
> > ---
> > This macro is not used anywhere. Should we just correct the
> > spelling or remove the macro?
> >
> > drivers/staging/iio/cdc/ad7152.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> > index 25f51db..c9da6d4 100644
> > --- a/drivers/staging/iio/cdc/ad7152.c
> > +++ b/drivers/staging/iio/cdc/ad7152.c
> > @@ -35,7 +35,7 @@
> > #define AD7152_REG_CH2_GAIN_HIGH 12
> > #define AD7152_REG_CH2_SETUP 14
> > #define AD7152_REG_CFG 15
> > -#define AD7152_REG_RESEVERD 16
> > +#define AD7152_REG_RESERVED 16
> > #define AD7152_REG_CAPDAC_POS 17
> > #define AD7152_REG_CAPDAC_NEG 18
> > #define AD7152_REG_CFG2 26
> > --
> > 2.7.4
> >
Powered by blists - more mailing lists