linux-kernel - Re: [PATCH 1/2] staging: erofs: use xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190125132614.GB1795@kadam>
Date:   Fri, 25 Jan 2019 16:26:14 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Gao Xiang <gaoxiang25@...wei.com>
Cc:     Chao Yu <yuchao0@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-erofs@...ts.ozlabs.org,
        Chao Yu <chao@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        weidu.du@...wei.com, Fang Wei <fangwei1@...wei.com>,
        Miao Xie <miaoxie@...wei.com>
Subject: Re: [PATCH 1/2] staging: erofs: use xattr_prefix to wrap up

On Fri, Jan 25, 2019 at 07:51:03PM +0800, Gao Xiang wrote:
> Let's use xattr_prefix instead of open code.
> No logic changes.
> 
> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> ---
>  drivers/staging/erofs/xattr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
> index 1c9498e38f0e..eca65df46133 100644
> --- a/drivers/staging/erofs/xattr.c
> +++ b/drivers/staging/erofs/xattr.c
> @@ -521,7 +521,7 @@ static int xattr_entrylist(struct xattr_iter *_it,
>  		return 1;
>  
>  	/* Note that at least one of 'prefix' and 'name' should be non-NULL */

The comment is sort of confusing now.

> -	prefix = h->prefix != NULL ? h->prefix : h->name;
> +	prefix = xattr_prefix(h);
>  	prefix_len = strlen(prefix);

regards,
dan carpenter