linux-kernel - Re: [PATCH] Kbuild: Handle too long symbols in kallsyms.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Jan 2019 14:28:48 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     eugene.loh@...cle.com
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>, andi@...stfloor.org
Subject: Re: [PATCH] Kbuild: Handle too long symbols in kallsyms.c

On Thu, 17 Jan 2019 at 23:46, <eugene.loh@...cle.com> wrote:
>
> From: Eugene Loh <eugene.loh@...cle.com>
>
> When checking for symbols with excessively long names,
> account for null terminating character.
>
> Fixes: f3462aa952cf ("Kbuild: Handle longer symbols in kallsyms.c")
> Signed-off-by: Eugene Loh <eugene.loh@...cle.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> ---
>  scripts/kallsyms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 77cebad..f75e7bd 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -118,8 +118,8 @@ static int read_symbol(FILE *in, struct sym_entry *s)
>                         fprintf(stderr, "Read error or end of file.\n");
>                 return -1;
>         }
> -       if (strlen(sym) > KSYM_NAME_LEN) {
> -               fprintf(stderr, "Symbol %s too long for kallsyms (%zu vs %d).\n"
> +       if (strlen(sym) >= KSYM_NAME_LEN) {
> +               fprintf(stderr, "Symbol %s too long for kallsyms (%zu >= %d).\n"
>                                 "Please increase KSYM_NAME_LEN both in kernel and kallsyms.c\n",
>                         sym, strlen(sym), KSYM_NAME_LEN);
>                 return -1;
> --
> 1.8.3.1
>