linux-kernel - Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190126191143.GB25003@archlinux-ryzen>
Date:   Sat, 26 Jan 2019 12:11:43 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     GOTO Masanori <gotom@...ian.or.jp>,
        YOKOTA Hiroshi <yokota@...lab.is.tsukuba.ac.jp>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in
 nsp32_set_sync_entry

On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of
> variable of type 'unsigned char' to itself [-Wself-assign]
>         offset      = offset;
>         ~~~~~~      ^
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/scsi/nsp32.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 5aac3e801903..7ce6e7acf2f3 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -2441,7 +2441,6 @@ static void nsp32_set_sync_entry(nsp32_hw_data *data,
>  
>  	period      = data->synct[entry].period_num;
>  	ackwidth    = data->synct[entry].ackwidth;
> -	offset      = offset;
>  	sample_rate = data->synct[entry].sample_rate;
>  
>  	target->syncreg    = TO_SYNCREG(period, offset);
> -- 
> 2.20.0
> 

Ping?