linux-kernel - Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALZLnaEkikS6Yv-PR-kBpnrCRrn9A8yHg+ZYGXkq+d_JQvR23g@mail.gmail.com>
Date:   Sun, 27 Jan 2019 17:42:01 +0900
From:   Masanori Goto <gotom@...ian.or.jp>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     YOKOTA Hiroshi <yokota@...lab.is.tsukuba.ac.jp>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

Thanks for the fix!

2019年1月27日(日) 4:11 Nathan Chancellor <natechancellor@...il.com>:
>
> On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote:
> > Clang warns:
> >
> > drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of
> > variable of type 'unsigned char' to itself [-Wself-assign]
> >         offset      = offset;
> >         ~~~~~~      ^
> >
> > Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Acked-by: GOTO Masanori <gotom@...ian.or.jp>

> > ---
> >  drivers/scsi/nsp32.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> > index 5aac3e801903..7ce6e7acf2f3 100644
> > --- a/drivers/scsi/nsp32.c
> > +++ b/drivers/scsi/nsp32.c
> > @@ -2441,7 +2441,6 @@ static void nsp32_set_sync_entry(nsp32_hw_data *data,
> >
> >       period      = data->synct[entry].period_num;
> >       ackwidth    = data->synct[entry].ackwidth;
> > -     offset      = offset;
> >       sample_rate = data->synct[entry].sample_rate;
> >
> >       target->syncreg    = TO_SYNCREG(period, offset);
> > --
> > 2.20.0
> >
>
> Ping?