linux-kernel - Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Jan 2019 18:23:48 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Masanori Goto <gotom@...ian.or.jp>
Cc:     YOKOTA Hiroshi <yokota@...lab.is.tsukuba.ac.jp>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in
 nsp32_set_sync_entry

On Sun, Jan 27, 2019 at 05:42:01PM +0900, Masanori Goto wrote:
> Thanks for the fix!
> 
> 2019年1月27日(日) 4:11 Nathan Chancellor <natechancellor@...il.com>:
> >
> > On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote:
> > > Clang warns:
> > >
> > > drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of
> > > variable of type 'unsigned char' to itself [-Wself-assign]
> > >         offset      = offset;
> > >         ~~~~~~      ^
> > >
> > > Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> 
> Acked-by: GOTO Masanori <gotom@...ian.or.jp>

Thank you for the reply and the review :)

Nathan

> 
> > > ---
> > >  drivers/scsi/nsp32.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> > > index 5aac3e801903..7ce6e7acf2f3 100644
> > > --- a/drivers/scsi/nsp32.c
> > > +++ b/drivers/scsi/nsp32.c
> > > @@ -2441,7 +2441,6 @@ static void nsp32_set_sync_entry(nsp32_hw_data *data,
> > >
> > >       period      = data->synct[entry].period_num;
> > >       ackwidth    = data->synct[entry].ackwidth;
> > > -     offset      = offset;
> > >       sample_rate = data->synct[entry].sample_rate;
> > >
> > >       target->syncreg    = TO_SYNCREG(period, offset);
> > > --
> > > 2.20.0
> > >
> >
> > Ping?