linux-kernel - Re: [PATCH v2] HID: debug: fix the ring buffer implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190128111818.GA22143@redhat.com>
Date:   Mon, 28 Jan 2019 12:18:19 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Vladis Dronov <vdronov@...hat.com>, Jiri Kosina <jikos@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "3.8+" <stable@...r.kernel.org>
Subject: Re: [PATCH v2] HID: debug: fix the ring buffer implementation

On 01/28, Benjamin Tissoires wrote:
>
> Oleg, can you provide some feedback before I push this?

Looks good to me, feel free to add

Reviewed-by: Oleg Nesterov <oleg@...hat.com>

> > +               set_current_state(TASK_RUNNING);

I still think that

		    __set_current_state(TASK_RUNNING);

will look a bit better, but this is really minor.

Oleg.