linux-kernel - Re: [PATCH v2] HID: debug: fix the ring buffer implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO-hwJK_WoimsUMR19GR_qEUCk0ZMaKGham3DSJ5SDqtc8oCzw@mail.gmail.com>
Date:   Tue, 29 Jan 2019 10:33:22 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Oleg Nesterov <oleg@...hat.com>, Vladis Dronov <vdronov@...hat.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "3.8+" <stable@...r.kernel.org>
Subject: Re: [PATCH v2] HID: debug: fix the ring buffer implementation

Vlad,

On Mon, Jan 28, 2019 at 12:18 PM Oleg Nesterov <oleg@...hat.com> wrote:
>
> On 01/28, Benjamin Tissoires wrote:
> >
> > Oleg, can you provide some feedback before I push this?
>
> Looks good to me, feel free to add
>
> Reviewed-by: Oleg Nesterov <oleg@...hat.com>
>
> > > +               set_current_state(TASK_RUNNING);
>
> I still think that
>
>                     __set_current_state(TASK_RUNNING);
>
> will look a bit better, but this is really minor.

Would you mind sending a v3 with this change? I'll apply it ASAP.

Cheers,
Benjamin