linux-kernel - Re: [PATCH 3/3] Staging: media: ipu3: fixed max charecter style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Jan 2019 14:54:50 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Prashantha SP <prashanth.sp98@...il.com>
Cc:     sakari.ailus@...ux.intel.com, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        mchehab@...nel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: media: ipu3: fixed max charecter style issue

On Sun, Jan 27, 2019 at 10:24:16PM +0530, Prashantha SP wrote:
> fixed coding style issue.
> 
> Signed-off-by: Prashantha SP <prashanth.sp98@...il.com>
                            ^^

Please use your full name that you would use to sign legal documents.

> ---
>  drivers/staging/media/ipu3/ipu3-css.c | 178 ++++++++++++++------------
>  1 file changed, 94 insertions(+), 84 deletions(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index 44c55639389a..466a1a8cc422 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -186,7 +186,8 @@ static bool ipu3_css_queue_enabled(struct ipu3_css_queue *q)
>  /******************* css hw *******************/
>  
>  /* In the style of writesl() defined in include/asm-generic/io.h */
> -static inline void writes(const void *mem, ssize_t count, void __iomem *addr)
> +static inline void writes(const void *mem, ssize_t count,
> +			  void __iomem *addr)
>  {
>  	if (count >= 4) {
>  		const u32 *buf = mem;
> @@ -671,8 +672,9 @@ static void ipu3_css_pipeline_cleanup(struct ipu3_css *css, unsigned int pipe)
>  	ipu3_css_pool_cleanup(imgu, &css->pipes[pipe].pool.obgrid);
>  
>  	for (i = 0; i < IMGU_ABI_NUM_MEMORIES; i++)
> -		ipu3_css_pool_cleanup(imgu,
> -				      &css->pipes[pipe].pool.binary_params_p[i]);
> +		ipu3_css_pool_cleanup
> +			(imgu,
> +			&css->pipes[pipe].pool.binary_params_p[i]);

The original is better.

regards,
dan carpenter