linux-kernel - Re: [PATCH] ext2: Remove useless reset code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190128144847.GG27972@quack2.suse.cz>
Date:   Mon, 28 Jan 2019 15:48:47 +0100
From:   Jan Kara <jack@...e.cz>
To:     Liu Xiang <liu.xiang6@....com.cn>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, liuxiang_1999@....com
Subject: Re: [PATCH] ext2: Remove useless reset code

On Fri 25-01-19 22:01:04, Liu Xiang wrote:
> If ((char *)de == dir_end) is true, the name_len will not be used
> in the subsequent routine. So the reset code can be removed.
> 
> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>

Thanks for the patch. I agree with your analysis but I prefer to keep the
code as is - it prevents warnings about uninitialized variable being used
for compilers than cannot infer that and also for humans reading the code
is easier this way.

								Honza

> ---
>  fs/ext2/dir.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c
> index 3b8114d..5ec497f 100644
> --- a/fs/ext2/dir.c
> +++ b/fs/ext2/dir.c
> @@ -517,7 +517,6 @@ int ext2_add_link (struct dentry *dentry, struct inode *inode)
>  		while ((char *)de <= kaddr) {
>  			if ((char *)de == dir_end) {
>  				/* We hit i_size */
> -				name_len = 0;
>  				rec_len = chunk_size;
>  				de->rec_len = ext2_rec_len_to_disk(chunk_size);
>  				de->inode = 0;
> -- 
> 1.9.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR