linux-kernel - Re: [PATCH] x86/events: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db4c4c57-fcdb-5101-a3b6-d1f3c587185e@embeddedor.com>
Date:   Tue, 29 Jan 2019 10:19:59 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] x86/events: Mark expected switch fall-throughs



On 1/29/19 10:07 AM, Borislav Petkov wrote:
> On Tue, Jan 29, 2019 at 09:58:05AM -0600, Gustavo A. R. Silva wrote:
>> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback arch/x86/events/intel/core.c
> 
> You need to have -f when supplying a file:
> 
> scripts/get_maintainer.pl -f arch/x86/events/intel/core.c
> 

You're correct.  I used the command I use for patches.

> and the pattern is there:
> 
> PERFORMANCE EVENTS SUBSYSTEM
> M:      Peter Zijlstra <peterz@...radead.org>
> ...
> F:      arch/*/events/*
> 
> yet it still doesn't list Peter as maintainer:
> 

Yep. And this is the reason why I didn't include him.

> Thomas Gleixner <tglx@...utronix.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> Ingo Molnar <mingo@...hat.com> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),commit_signer:21/22=95%)
> Borislav Petkov <bp@...en8.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> "H. Peter Anvin" <hpa@...or.com> (reviewer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> x86@...nel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> Peter Zijlstra <peterz@...radead.org> (commit_signer:19/22=86%,authored:3/22=14%,added_lines:22/382=6%,removed_lines:13/122=11%)
> Kan Liang <kan.liang@...ux.intel.com> (commit_signer:11/22=50%,authored:10/22=45%,added_lines:144/382=38%,removed_lines:73/122=60%)
> Jiri Olsa <jolsa@...nel.org> (commit_signer:4/22=18%,authored:4/22=18%,added_lines:99/382=26%,removed_lines:32/122=26%)
> Andi Kleen <ak@...ux.intel.com> (added_lines:113/382=30%)
> linux-kernel@...r.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
> 
> if you change the pattern to
> 
> F:      arch/*/events/
> 
> i.e., drop the '*', then it works:
> 
> $ scripts/get_maintainer.pl -f arch/x86/events/intel/core.c

Yeah. But I don't want to send patches to every person that has touched the file.

> Peter Zijlstra <peterz@...radead.org> (supporter:PERFORMANCE EVENTS SUBSYSTEM,commit_signer:19/22=86%,authored:3/22=14%,added_lines:22/382=6%,removed_lines:13/122=11%)
> Ingo Molnar <mingo@...hat.com> (supporter:PERFORMANCE EVENTS SUBSYSTEM,commit_signer:21/22=95%)
> Arnaldo Carvalho de Melo <acme@...nel.org> (supporter:PERFORMANCE EVENTS SUBSYSTEM)
> Alexander Shishkin <alexander.shishkin@...ux.intel.com> (reviewer:PERFORMANCE EVENTS SUBSYSTEM)
> Jiri Olsa <jolsa@...hat.com> (reviewer:PERFORMANCE EVENTS SUBSYSTEM,commit_signer:4/22=18%,authored:4/22=18%,added_lines:99/382=26%,removed_lines:32/122=26%)
> Namhyung Kim <namhyung@...nel.org> (reviewer:PERFORMANCE EVENTS SUBSYSTEM)
> ...
> 

--
Gustavo