linux-kernel - Re: [PATCH RFC 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <625436113.118199.1548879811777@email.ionos.de>
Date:   Wed, 30 Jan 2019 21:23:31 +0100 (CET)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Kamil Debski <kamil@...as.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Jean Delvare <jdelvare@...e.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 1/3] dt-bindings: hwmon: Add tachometer interrupt to
 pwm-fan

Hi Guenter,

> Guenter Roeck <linux@...ck-us.net> hat am 30. Januar 2019 um 18:28 geschrieben:
> 
> 
> On Wed, Jan 30, 2019 at 04:07:05PM +0100, Stefan Wahren wrote:
> > This adds the tachometer interrupt to the pwm-fan binding, which is
> > necessary for RPM support.
> > 
> > Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
> > ---
> >  Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> > index 49ca5d8..7f69b0b 100644
> > --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> > +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> > @@ -8,6 +8,9 @@ Required properties:
> >  
> >  Optional properties:
> >  - fan-supply    : phandle to the regulator that provides power to the fan
> > +- interrupts    : contains a single interrupt specifier which describes the
> > +                  tachometer pin output of a 2 pulse-per-revolution fan.
> > +                  See interrupt-controller/interrupts.txt for the format.
> 
> So a hypothetical {1,4} pulse-per-revolution fan would explicitly not be
> supported ? Why ?

i could add an additional property to specify the pulse per revolution and use the 2 as default (according to the Intel spec for 4 pin pwm fan) which should fit in most cases.

> 
> Guenter