linux-kernel - Re: [PATCH] Documentation/process: hardcoded core.abbrev considered harmful!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82a0b13b-edfc-46cc-ac7c-005f973009c4@gmail.com>
Date:   Wed, 30 Jan 2019 15:36:49 -0800
From:   Frank Rowand <frowand.list@...il.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Ævar Arnfjörð Bjarmason <avarab@...il.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Jacob Keller <jacob.e.keller@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] Documentation/process: hardcoded core.abbrev considered
 harmful!

On 1/29/19 4:18 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 20 Dec 2018 01:01:12 +0100 Ævar Arnfjörð Bjarmason <avarab@...il.com> wrote:
>>
>> Stop recommending that core.abbrev=12 be hardcoded when referring to
>> kernel commits, and instead rely on the git's default abbreviation.
>>
>> Hardcoding this at "12" was done in
>> 8401aa1f5997 ("Documentation/SubmittingPatches: describe the Fixes:
>> tag", 2014-06-06), back then Linus's git/git@...587c733 ("abbrev: auto
>> size the default abbreviation", 2016-09-30) had not yet landed, and
>> the default abbreviation was "7".
>>
>> At the time linux.git had around 3.5 million objects, so if the auto
>> sizing had been in effect "11" would have been picked. Now "12" is
>> what we pick by default anyway.
>>
>> More importantly, we'll roll over to "13" at around 16 million
>> objects, which given the growth rate isn't that far off. At that point
>> this documentation will be worse than the default.
>>
>> Let's just stop doing this. Git versions as of 2.11 released over 2
>> years ago use the auto-sizing, and it seems like a fair assumption
>> that kernel developers use a fairly recent git version.

That might not be a fair assumption.  The two systems that I submit
patches from have git versions older than 2.11.

-Frank


>>
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@...il.com>
> 
> Acked-by: Stephen Rothwell <sfr@...b.auug.org.au>
> 
> Since I have been checking Fixes: tags, it has become obvious that some
> kernel developers have core.abbrev set to 7, 9 or 10 (or maybe they are
> running very old versions of git).  Hopefully this will encourage them
> to remove that setting (and upgrade).
> 
> Can someone (Jon?) please apply this patch?
>