linux-kernel - Re: [PATCH] tty: ldisc: add sysctl to prevent autoloading of ldiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190130082857.GB24317@kroah.com>
Date:   Wed, 30 Jan 2019 09:28:57 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Theodore Y. Ts'o" <tytso@....edu>,
        kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH] tty: ldisc: add sysctl to prevent autoloading of ldiscs

On Mon, Jan 21, 2019 at 07:01:42PM -0500, Theodore Y. Ts'o wrote:
> On Mon, Jan 21, 2019 at 05:26:42PM +0100, Greg Kroah-Hartman wrote:
> > By default, the kernel will automatically load the module of any line
> > dicipline that is asked for.  As this sometimes isn't the safest thing
> > to do, provide a sysctl to disable this feature.
> > 
> > By default, we set this to 'y' as that is the historical way that Linux
> > has worked, and we do not want to break working systems.  But in the
> > future, perhaps this can default to 'n' to prevent this functionality.
> > 
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Reviewed-by: Theodore Ts'o <tytso@....edu>

Thanks for the review!