linux-kernel - Re: [PATCH 2/2] regulator: max77650: Convert to use regulator_enable/disable/is_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFRkauCsJdK43YttVNexcVRozKGxJ-4YLjwTWjxxkA=C5f_SAA@mail.gmail.com>
Date:   Wed, 30 Jan 2019 17:14:04 +0800
From:   Axel Lin <axel.lin@...ics.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] regulator: max77650: Convert to use regulator_enable/disable/is_enabled_regmap

Bartosz Golaszewski <bgolaszewski@...libre.com> 於 2019年1月30日 週三 下午5:12寫道：
>
> śr., 30 sty 2019 o 10:07 Axel Lin <axel.lin@...ics.com> napisał(a):
> >
> > By setting enable_reg, enable_mask, enable_val and disable_val, we can
> > use the regulator_enable/disable/is_enabled_regmap helpers. With this
> > change, then regB field can be removed from struct max77650_regulator_desc.
> >
> > Signed-off-by: Axel Lin <axel.lin@...ics.com>
> > ---
> > Hi Bartosz,
> > I don't have this h/w, please help to review and test it.
> >
> > I think the only difference is the is_enabled checking:
> > Before the patch, it returns en != MAX77650_REGULATOR_DISABLED;
> > After the patch, it returns en == MAX77650_REGULATOR_ENABLED
> > I'm not sure if this difference does matter or not.
> >
>
> NACK. I intend to support the FPS feature of the regulator module in
> the future (see a similar thing in max77620) and I will need to extend
> these callbacks as there will be more possible values here. Regmap
> generics will not be enough.
Got it, thanks for the quick review.