linux-kernel - Re: [PATCH v8 0/8] Introduce the for_each_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Jan 2019 19:18:14 +0900
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>, linus.walleij@...aro.org
Cc:     linux-gpio@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        linux@...musvillemoes.dk
Subject: Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro

On Tue, Jan 29, 2019 at 05:07:34PM -0800, Andrew Morton wrote:
> Do we have any expectation that these facilities will be used by
> anything other than GPIO?  If not then perhaps they should be sited
> within drivers/gpio (presumably as a standalone module) until such a
> need is found?

I can move it within drivers/gpio since my only use at moment is for
these gpio drivers I maintain. However, moving it to the gpio subsystem
does make it less likely to be seen by authors in other subsystems who
may have use for it -- so there is the chance that this becomes isolated
and untilized only amonst the gpio drivers. That may not be such a bad
thing in the end; I suspect it will be easy to spot if other subsystems
start implementing their own for_each_set_clump (if other subsystems
would even have such a need for it).

Linus, if I move the for_each_set_clump macro and related functions to
drivers/gpio, should I move the code into the gpiolib.h and gpiolib.c
files? Or would it be best to implement this as a separate standalone
module, and make a Kconfig dependency for those gpio drivers which
require it? A standalone module feels somewhat overkill for such little
code in my opinion.

William Breathitt Gray