linux-kernel - Re: [PATCH v2 7/9] usb: typec: Find the ports by also matching against the device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Jan 2019 18:51:56 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chen Yu <chenyu56@...wei.com>, Jun Li <jun.li@....com>,
        Hans de Goede <hdegoede@...hat.com>,
        USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 7/9] usb: typec: Find the ports by also matching
 against the device node

On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
>
> When the connections are defined in firmware, struct
> device_connection will have the fwnode member pointing to
> the device node (struct fwnode_handle) of the requested
> device, and the endpoint will not be used at all in that
> case.

> +       /*
> +        * FIXME: Check does the fwnode supports the requested SVID. If it does
> +        * we need to return ERR_PTR(-PROBE_DEFER) when there is no device.
> +        */
> +       if (con->fwnode)
> +               return class_find_device(typec_class, NULL, con->fwnode,
> +                                        typec_port_fwnode_match);
> +
> +       dev = class_find_device(typec_class, NULL, con->endpoint[ep],
> +                               typec_port_name_match);
> +
> +       return dev ? dev : ERR_PTR(-EPROBE_DEFER);

Just  to be clear, this one takes a reference on dev. Is it taken into account?

-- 
With Best Regards,
Andy Shevchenko