linux-kernel - Re: [PATCH v2 0/9] device connection: Add support for device graphs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07262cf3-c512-d3dd-f383-3795f035a2d5@redhat.com>
Date:   Thu, 31 Jan 2019 11:06:29 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Chen Yu <chenyu56@...wei.com>, Jun Li <jun.li@....com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/9] device connection: Add support for device graphs

Hi,

On 30-01-19 17:02, Heikki Krogerus wrote:
> Hi,
> 
> This is the second version of this series. On top the two code style
> improvements requested by Andy, I also renamed the connection
> identifiers used with the USB Type-C muxes for something that I felt
> are better, especially after we start using them to name reference
> device properties in fwnodes. That's why the first patch is now split
> in two, 1/9 and 3/9.
> 
> Hans! Please note that there is no functional change. The alt mode
> device is still getting a handle to the mux, just like before.

Ack.

I've reviewed the entire series and it looks good to me.

Patches 1-3 are:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

I'm slightly less familiar with the material in patches 4-9, so they
are:

Acked-by: Hans de Goede <hdegoede@...hat.com>

I will also add this series to my personal git tree for testing.

Regards,

Hans




> That was actually happening also in the first version of the series.
> 
> The commit message from v1:
> 
> This series adds support for OF and ACPI device graph parsing to the
> device connection API.
> 
> Handling the graph is straightforward, but because I'm adding that
> fwnode member to struct device_connection, I had to make sure all the
> existing users consider it.
> 
> The plan is to only support matching with fwnode in the future, so no
> more device name matching. The software fwnodes that we now have in
> kernel should make that possible, once we add support for references
> to them.
> 
> The original RFC:
> https://lkml.org/lkml/2018/10/24/619
> 
> thanks,
> 
> Heikki Krogerus (9):
>    platform/x86: intel_cht_int33fe: Prepare for better mux naming scheme
>    usb: typec: Rationalize the API for the muxes
>    platform/x86: intel_cht_int33fe: Remove old style mux connections
>    device connection: Add fwnode member to struct device_connection
>    usb: typec: mux: Find the muxes by also matching against the device
>      node
>    usb: roles: Find the muxes by also matching against the device node
>    usb: typec: Find the ports by also matching against the device node
>    device connection: Prepare support for firmware described connections
>    device connection: Find device connections also from device graphs
> 
>   drivers/base/devcon.c                    | 62 ++++++++++++++-
>   drivers/platform/x86/intel_cht_int33fe.c | 15 ++--
>   drivers/usb/roles/class.c                | 21 +++++-
>   drivers/usb/typec/class.c                | 31 ++++++--
>   drivers/usb/typec/mux.c                  | 96 ++++++++++++++++++++----
>   include/linux/device.h                   |  6 ++
>   include/linux/usb/role.h                 |  1 +
>   include/linux/usb/typec_mux.h            |  3 +-
>   8 files changed, 195 insertions(+), 40 deletions(-)
>