linux-kernel - Re: linux-next: powerpc le qemu boot failure after merge of the akpm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Jan 2019 17:06:29 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        PowerPC <linuxppc-dev@...ts.ozlabs.org>,
        Christophe Leroy <christophe.leroy@....fr>
Subject: Re: linux-next: powerpc le qemu boot failure after merge of the
 akpm tree

Hi all,

On Thu, 31 Jan 2019 16:38:54 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> [I am guessing that is is something in Andrew's tree that has caused
> this.]
> 
> My qemu boot of the powerpc pseries_le_defconfig config failed like this:
> 
> htab_hash_mask    = 0x1ffff
> -----------------------------------------------------
> numa:   NODE_DATA [mem 0x7ffe7000-0x7ffebfff]
> Kernel panic - not syncing: sparse_buffer_init: Failed to allocate 2147483648 bytes align=0x10000 nid=0 from=fffffffffffffff
> CPU: 0 PID: 0 Comm: swapper Not tainted 5.0.0-rc4 #2
> Call Trace:
> [c00000000105bbd0] [c000000000b1345c] dump_stack+0xb0/0xf4 (unreliable)
> [c00000000105bc10] [c000000000111120] panic+0x168/0x3b8
> [c00000000105bcb0] [c000000000e701c8] sparse_init_nid+0x178/0x550
> [c00000000105bd70] [c000000000e709b4] sparse_init+0x210/0x238
> [c00000000105bdb0] [c000000000e468f4] initmem_init+0x1e0/0x260
> [c00000000105be80] [c000000000e3b9b0] setup_arch+0x354/0x3d4
> [c00000000105bef0] [c000000000e33afc] start_kernel+0x98/0x648
> [c00000000105bf90] [c00000000000b270] start_here_common+0x1c/0x52c

A quick bisect leads to this:

1c3c9328cde027eb875ba4692f0a5d66b0afe862 is the first bad commit
commit 1c3c9328cde027eb875ba4692f0a5d66b0afe862
Author: Mike Rapoport <rppt@...ux.ibm.com>
Date:   Thu Jan 31 10:51:32 2019 +1100

    treewide: add checks for the return value of memblock_alloc*()
    
    Add check for the return value of memblock_alloc*() functions and call
    panic() in case of error.  The panic message repeats the one used by
    panicing memblock allocators with adjustment of parameters to include only
    relevant ones.
    
    The replacement was mostly automated with semantic patches like the one
    below with manual massaging of format strings.
    
    @@
    expression ptr, size, align;
    @@
    ptr = memblock_alloc(size, align);
    + if (!ptr)
    +       panic("%s: Failed to allocate %lu bytes align=0x%lx\n", __func__,
    size, align);
    
    Link: http://lkml.kernel.org/r/1548057848-15136-20-git-send-email-rppt@linux.ibm.com
    Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>
    Reviewed-by: Guo Ren <ren_guo@...ky.com>                [c-sky]
    Acked-by: Paul Burton <paul.burton@...s.com>            [MIPS]
    Acked-by: Heiko Carstens <heiko.carstens@...ibm.com>    [s390]
    Reviewed-by: Juergen Gross <jgross@...e.com>            [Xen]
    Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>  [m68k]
    Cc: Catalin Marinas <catalin.marinas@....com>
    Cc: Christophe Leroy <christophe.leroy@....fr>
    Cc: Christoph Hellwig <hch@....de>
    Cc: "David S. Miller" <davem@...emloft.net>
    Cc: Dennis Zhou <dennis@...nel.org>
    Cc: Greentime Hu <green.hu@...il.com>
    Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
    Cc: Guan Xuetao <gxt@....edu.cn>
    Cc: Guo Ren <guoren@...nel.org>
    Cc: Mark Salter <msalter@...hat.com>
    Cc: Matt Turner <mattst88@...il.com>
    Cc: Max Filippov <jcmvbkbc@...il.com>
    Cc: Michael Ellerman <mpe@...erman.id.au>
    Cc: Michal Simek <monstr@...str.eu>
    Cc: Petr Mladek <pmladek@...e.com>
    Cc: Richard Weinberger <richard@....at>
    Cc: Rich Felker <dalias@...c.org>
    Cc: Rob Herring <robh+dt@...nel.org>
    Cc: Rob Herring <robh@...nel.org>
    Cc: Russell King <linux@...linux.org.uk>
    Cc: Stafford Horne <shorne@...il.com>
    Cc: Tony Luck <tony.luck@...el.com>
    Cc: Vineet Gupta <vgupta@...opsys.com>
    Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Which is just adding the panic we hit.  So, presumably, the bug is in a
preceding patch :-(

I have left the kernel not booting for today.
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped