linux-kernel - Re: [PATCH 1/9] spi: atmel-quadspi: optimize qspi init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ae8f1c2-b201-f7ee-5715-e49f39b9cdc1@microchip.com>
Date:   Thu, 31 Jan 2019 10:42:45 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <bbrezillon@...nel.org>
CC:     <broonie@...nel.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Ludovic.Desroches@...rochip.com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-spi@...r.kernel.org>
Subject: Re: [PATCH 1/9] spi: atmel-quadspi: optimize qspi init



On 01/30/2019 07:15 PM, Boris Brezillon wrote:
> On Wed, 30 Jan 2019 15:08:29 +0000
> <Tudor.Ambarus@...rochip.com> wrote:
> 
>> From: Tudor Ambarus <tudor.ambarus@...rochip.com>
>>
>> Set the QSPI controller in Serial Memory Mode at init and not
>> at each exec_op() call.
> 
> If you ever want to support regular SPI you'll have to put it back to
> atmel_qspi_exec_op(), so I'm not sure this is a good move. Another
> approach would be to cache the MR value to avoid doing a write access
> on the bus when the value hasn't changed.

I'll cache MR value, thanks!

ta