[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5C53FB63.8040502@hisilicon.com>
Date: Fri, 1 Feb 2019 15:55:15 +0800
From: Chen Feng <puck.chen@...ilicon.com>
To: Qing Xia <saberlily.xia@...ilicon.com>, <labbott@...hat.com>,
<sumit.semwal@...aro.org>, <gregkh@...uxfoundation.org>,
<arve@...roid.com>, <tkjos@...roid.com>, <maco@...roid.com>
CC: <linaro-mm-sig@...ts.linaro.org>, <linux-kernel@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>, <devel@...verdev.osuosl.org>,
<daniel.liuyi@...ilicon.com>, <yudongbin@...ilicon.com>,
<kongfei@...ilicon.com>
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags
Thanks.
On 2019/2/1 14:59, Qing Xia wrote:
> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
> and there will be no chance to change back to low_order_gfp_flags.
>
> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
> Signed-off-by: Qing Xia <saberlily.xia@...ilicon.com>
> ---
> drivers/staging/android/ion/ion_system_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index 0383f75..20f2103 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools)
> static int ion_system_heap_create_pools(struct ion_page_pool **pools)
> {
> int i;
> - gfp_t gfp_flags = low_order_gfp_flags;
>
> for (i = 0; i < NUM_ORDERS; i++) {
> struct ion_page_pool *pool;
> + gfp_t gfp_flags = low_order_gfp_flags;
>
> if (orders[i] > 4)
> gfp_flags = high_order_gfp_flags;
>
--
Cheers,
- Feng
Powered by blists - more mailing lists