linux-kernel - Re: [PATCH] staging: android: ion: fix sys heap pool's gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190201081530.GC14343@kadam>
Date:   Fri, 1 Feb 2019 11:15:30 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Qing Xia <saberlily.xia@...ilicon.com>
Cc:     labbott@...hat.com, sumit.semwal@...aro.org,
        gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
        maco@...roid.com, devel@...verdev.osuosl.org,
        puck.chen@...ilicon.com, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, kongfei@...ilicon.com,
        linaro-mm-sig@...ts.linaro.org, daniel.liuyi@...ilicon.com,
        yudongbin@...ilicon.com
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote:
> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
> and there will be no chance to change back to low_order_gfp_flags.
> 
> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")

Huh...  Presumably you found this bug just by reading the code.  I
wonder how it affects runtime?

regards,
dan carpenter