linux-kernel - Re: [PATCH] staging: android: ion: fix sys heap pool's gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b39b4839-ee9a-802b-8d46-674a61adfa8c@hisilicon.com>
Date:   Fri, 1 Feb 2019 16:30:53 +0800
From:   "Xiaqing (A)" <saberlily.xia@...ilicon.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     <labbott@...hat.com>, <sumit.semwal@...aro.org>,
        <gregkh@...uxfoundation.org>, <arve@...roid.com>,
        <tkjos@...roid.com>, <maco@...roid.com>,
        <devel@...verdev.osuosl.org>, <puck.chen@...ilicon.com>,
        <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <kongfei@...ilicon.com>, <linaro-mm-sig@...ts.linaro.org>,
        <daniel.liuyi@...ilicon.com>, <yudongbin@...ilicon.com>
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags



On 2019/2/1 16:15, Dan Carpenter wrote:
> On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote:
>> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
>> and there will be no chance to change back to low_order_gfp_flags.
>>
>> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
> 
> Huh...  Presumably you found this bug just by reading the code.  I
> wonder how it affects runtime?
> 
The problem is that when I found that there was no page allocation failure warning
after the failure of the ion alloc in my test, and then I found the problem of gfp_flags.

regards,
Qing

> regards,
> dan carpenter
> 
> 
> .
>