linux-kernel - Re: [PATCH] staging: android: ion: fix sys heap pool's gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f28e830-fd2b-c24b-3ffe-e711bb3cf3d3@redhat.com>
Date:   Tue, 19 Feb 2019 13:18:49 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Qing Xia <saberlily.xia@...ilicon.com>, sumit.semwal@...aro.org,
        gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
        maco@...roid.com
Cc:     linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, devel@...verdev.osuosl.org,
        daniel.liuyi@...ilicon.com, yudongbin@...ilicon.com,
        kongfei@...ilicon.com, puck.chen@...ilicon.com
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

On 1/31/19 10:59 PM, Qing Xia wrote:
> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
> and there will be no chance to change back to low_order_gfp_flags.
> 
> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
> Signed-off-by: Qing Xia <saberlily.xia@...ilicon.com>
> ---
>   drivers/staging/android/ion/ion_system_heap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index 0383f75..20f2103 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools)
>   static int ion_system_heap_create_pools(struct ion_page_pool **pools)
>   {
>   	int i;
> -	gfp_t gfp_flags = low_order_gfp_flags;
>   
>   	for (i = 0; i < NUM_ORDERS; i++) {
>   		struct ion_page_pool *pool;
> +		gfp_t gfp_flags = low_order_gfp_flags;
>   
>   		if (orders[i] > 4)
>   			gfp_flags = high_order_gfp_flags;
> 

Acked-by: Laura Abbott <labbott@...hat.com>