linux-kernel - Re: [PATCH 2/2] mfd: sec-core: Return gracefully instead of BUG() if device cannot match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190201092207.GF783@dell>
Date:   Fri, 1 Feb 2019 09:22:07 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Sangbeom Kim <sbkim73@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: sec-core: Return gracefully instead of BUG() if
 device cannot match

On Tue, 29 Jan 2019, Krzysztof Kozlowski wrote:

> Replace impossible BUG() in probe with a proper return.  This can be
> triggered only in case of a clear bug (e.g. adding broken half-support
> for new S2MPSXX flavor) but BUG() is discouraged and the boot process
> can actually try to continue.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/mfd/sec-core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog