linux-kernel - Re: [PATCH 1/2] mfd: sec-core: Cleanup formatting to a consistent style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Feb 2019 14:14:32 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Sangbeom Kim <sbkim73@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-kernel@...r.kernel.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH 1/2] mfd: sec-core: Cleanup formatting to a consistent style

On Fri, 1 Feb 2019 at 10:21, Lee Jones <lee.jones@...aro.org> wrote:
>
> On Tue, 29 Jan 2019, Krzysztof Kozlowski wrote:
>
> > Cleanup the formatting to have consistent style across the file (only
> > white-space issues).  No expected difference in code.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > ---
> >  drivers/mfd/sec-core.c | 17 ++++++++++-------
> >  1 file changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> > index e0835c9df7a1..c3bb53f79e63 100644
> > --- a/drivers/mfd/sec-core.c
> > +++ b/drivers/mfd/sec-core.c
> > @@ -70,9 +70,11 @@ static const struct mfd_cell s2mps11_devs[] = {
> >  };
> >
> >  static const struct mfd_cell s2mps13_devs[] = {
> > -     { .name = "s2mps13-regulator", },
> > -     { .name = "s2mps13-rtc", },
>
> I prefer one liners to remain on one line.

OK

>
> >       {
> > +             .name = "s2mps13-regulator",
> > +     }, {
> > +             .name = "s2mps13-rtc",
> > +     }, {
> >               .name = "s2mps13-clk",
> >               .of_compatible = "samsung,s2mps13-clk",
> >       },
> > @@ -114,7 +116,8 @@ static const struct mfd_cell s2mpu02_devs[] = {
> >
> >  #ifdef CONFIG_OF
> >  static const struct of_device_id sec_dt_match[] = {
> > -     {       .compatible = "samsung,s5m8767-pmic",
> > +     {
> > +             .compatible = "samsung,s5m8767-pmic",
> >               .data = (void *)S5M8767X,
>
> All of the other changes are fine.

OK, let me send v2.

Best regards,
Krzysztof