linux-kernel - Re: [PATCH ghak107 V1] audit: remove unused actx param from audit_rule_match

Open Source and information security mailing list archives

Message-ID: <20190201131435.cwwa3yiui2kk6x34@madcap2.tricolour.ca>
Date:   Fri, 1 Feb 2019 08:14:35 -0500
From:   Richard Guy Briggs <rgb@...hat.com>
To:     Paul Moore <paul@...l-moore.com>
Cc:     Linux Security Module list 
        <linux-security-module@...r.kernel.org>,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH ghak107 V1] audit: remove unused actx param from
 audit_rule_match

On 2019-01-31 23:15, Paul Moore wrote:
> On Thu, Jan 31, 2019 at 11:52 AM Richard Guy Briggs <rgb@...hat.com> wrote:
> >
> > The audit_rule_match() struct audit_context *actx parameter is not used
> > by any in-tree consumers (selinux, apparmour, integrity, smack).
> >
> > The audit context is an internal audit structure that should only be
> > accessed by audit accessor functions.
> >
> > It was part of commit 03d37d25e0f9 ("LSM/Audit: Introduce > generic
> > Audit LSM hooks") but appears to have never been used.
> 
> Merged into audit/next, but a heads-up that you added a ">" into the
> referenced commit title.  I'm not sure if that was a cut-n-paste
> problem, or something else, but just a note to be a bit more careful
> in the future about those things.

Ok, yes, that must have been a cut/paste error.  Pardon.

> > Remove it.
> >
> > Please see the github issue
> > https://github.com/linux-audit/audit-kernel/issues/107
> >
> > Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> > ---
> > Passes audit-testsuite.
> >
> >  include/linux/lsm_hooks.h           |  4 +---
> >  include/linux/security.h            |  5 ++---
> >  kernel/auditfilter.c                |  2 +-
> >  kernel/auditsc.c                    | 21 ++++++++++++---------
> >  security/apparmor/audit.c           |  3 +--
> >  security/apparmor/include/audit.h   |  3 +--
> >  security/integrity/ima/ima.h        |  3 +--
> >  security/integrity/ima/ima_policy.c |  6 ++----
> >  security/security.c                 |  6 ++----
> >  security/selinux/include/audit.h    |  4 +---
> >  security/selinux/ss/services.c      |  3 +--
> >  security/smack/smack_lsm.c          |  4 +---
> >  12 files changed, 26 insertions(+), 38 deletions(-)
> 
> -- 
> paul moore
> www.paul-moore.com
> 
> --
> Linux-audit mailing list
> Linux-audit@...hat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

- RGB

--
Richard Guy Briggs <rgb@...hat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives