[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHC9VhRqeeuVZdARyCSJBumrQtTf7053qMAsfJXJfDrzDOYXrg@mail.gmail.com>
Date: Thu, 31 Jan 2019 23:15:19 -0500
From: Paul Moore <paul@...l-moore.com>
To: Richard Guy Briggs <rgb@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
Linux-Audit Mailing List <linux-audit@...hat.com>,
Linux Security Module list
<linux-security-module@...r.kernel.org>,
Eric Paris <eparis@...hat.com>, Steve Grubb <sgrubb@...hat.com>
Subject: Re: [PATCH ghak107 V1] audit: remove unused actx param from audit_rule_match
On Thu, Jan 31, 2019 at 11:52 AM Richard Guy Briggs <rgb@...hat.com> wrote:
>
> The audit_rule_match() struct audit_context *actx parameter is not used
> by any in-tree consumers (selinux, apparmour, integrity, smack).
>
> The audit context is an internal audit structure that should only be
> accessed by audit accessor functions.
>
> It was part of commit 03d37d25e0f9 ("LSM/Audit: Introduce > generic
> Audit LSM hooks") but appears to have never been used.
Merged into audit/next, but a heads-up that you added a ">" into the
referenced commit title. I'm not sure if that was a cut-n-paste
problem, or something else, but just a note to be a bit more careful
in the future about those things.
> Remove it.
>
> Please see the github issue
> https://github.com/linux-audit/audit-kernel/issues/107
>
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
> Passes audit-testsuite.
>
> include/linux/lsm_hooks.h | 4 +---
> include/linux/security.h | 5 ++---
> kernel/auditfilter.c | 2 +-
> kernel/auditsc.c | 21 ++++++++++++---------
> security/apparmor/audit.c | 3 +--
> security/apparmor/include/audit.h | 3 +--
> security/integrity/ima/ima.h | 3 +--
> security/integrity/ima/ima_policy.c | 6 ++----
> security/security.c | 6 ++----
> security/selinux/include/audit.h | 4 +---
> security/selinux/ss/services.c | 3 +--
> security/smack/smack_lsm.c | 4 +---
> 12 files changed, 26 insertions(+), 38 deletions(-)
--
paul moore
www.paul-moore.com
Powered by blists - more mailing lists