linux-kernel - Re: [PATCH v2 2/4] crypto: hisilicon: Add queue management driver for HiSilicon QM module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190201153931.2k4yopm4akunpedg@gondor.apana.org.au>
Date:   Fri, 1 Feb 2019 23:39:31 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Zhou Wang <wangzhou1@...ilicon.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linuxarm@...wei.com,
        linux-kernel@...r.kernel.org, Kenneth Lee <liguozhu@...ilicon.com>,
        Shiju Jose <shiju.jose@...wei.com>,
        Hao Fang <fanghao11@...wei.com>
Subject: Re: [PATCH v2 2/4] crypto: hisilicon: Add queue management driver
 for HiSilicon QM module

On Fri, Feb 01, 2019 at 03:15:54PM +0800, Zhou Wang wrote:
>
> > Polling in softirq context is unacceptable.  Can't your hardware
> > send interrupts to signal completion? What is the average speed
> > of processing a single 1500-byte packet on your hardware?
> 
> Our hardware supports interrupt. In fact, implementation of compress/decompress
> interface of crypto_alg in v1 was done using interrupt:
> 
>  compress/decompress:
>      send task to hardware
>      wait task finished(wait_for_completion_timeout)
> 
>  In irq handler:
>      complete
> 
> However, there is get_cpu/put_cpu in scomp, wait and complete in above has to be
> changed to poll:
> 
>  compress/decompress:
>      send task to hardware
>      check if task is finished

If your hardware supports interrupts then you should be using
the acomp interface and not scomp.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt