linux-kernel - RE: [PATCH -next] remoteproc: make rproc_check_carveout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Feb 2019 15:56:13 +0000
From:   Loic PALLARDY <loic.pallardy@...com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "ohad@...ery.com" <ohad@...ery.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>
Subject: RE: [PATCH -next] remoteproc: make rproc_check_carveout_da static

Hi Yue,

> -----Original Message-----
> From: linux-remoteproc-owner@...r.kernel.org <linux-remoteproc-
> owner@...r.kernel.org> On Behalf Of YueHaibing
> Sent: vendredi 1 février 2019 04:13
> To: ohad@...ery.com; bjorn.andersson@...aro.org
> Cc: linux-kernel@...r.kernel.org; linux-remoteproc@...r.kernel.org;
> YueHaibing <yuehaibing@...wei.com>
> Subject: [PATCH -next] remoteproc: make rproc_check_carveout_da static
> 
> Fixes the following sparse warnings:
> 
> drivers/remoteproc/remoteproc_core.c:279:5: warning:
>  symbol 'rproc_check_carveout_da' was not declared. Should it be static?
Correction already sent on ML few weeks ago. See [1]

Regards,
Loic

[1] https://patchwork.kernel.org/patch/10755763/

> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/remoteproc/remoteproc_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 54ec38f..5d4954d 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -276,8 +276,9 @@ rproc_find_carveout_by_name(struct rproc *rproc,
> const char *name, ...)
>   *
>   * Return: 0 if carveout match request else -ENOMEM
>   */
> -int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry
> *mem,
> -			    u32 da, u32 len)
> +static int rproc_check_carveout_da(struct rproc *rproc,
> +				   struct rproc_mem_entry *mem,
> +				   u32 da, u32 len)
>  {
>  	struct device *dev = &rproc->dev;
>  	int delta = 0;
> --
> 2.7.0
>