linux-kernel - Re: [RESEND PATCH 1/2] loop: Report EOPNOTSUPP properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE=gft5Ug9eV3Gk4VW_pgrc0BVuXUZndtO-Zhocw+wWMCONQjQ@mail.gmail.com>
Date:   Fri, 1 Feb 2019 10:18:57 -0800
From:   Evan Green <evgreen@...omium.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Gwendal Grignou <gwendal@...omium.org>,
        Martin K Peterson <martin.peterson@...cle.com>,
        Alexis Savery <asavery@...omium.org>,
        Ming Lei <ming.lei@...hat.com>,
        linux-block <linux-block@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 1/2] loop: Report EOPNOTSUPP properly

On Thu, Jan 31, 2019 at 3:31 PM Bart Van Assche <bvanassche@....org> wrote:
>
> On Thu, 2019-01-31 at 14:13 -0800, Evan Green wrote:
> > diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> > index cf5538942834..a1ba555e3b92 100644
> > --- a/drivers/block/loop.c
> > +++ b/drivers/block/loop.c
> > @@ -458,8 +458,13 @@ static void lo_complete_rq(struct request *rq)
> >
> >       if (!cmd->use_aio || cmd->ret < 0 || cmd->ret == blk_rq_bytes(rq) ||
> >           req_op(rq) != REQ_OP_READ) {
> > -             if (cmd->ret < 0)
> > -                     ret = BLK_STS_IOERR;
> > +             if (cmd->ret < 0) {
> > +                     if (cmd->ret == -EOPNOTSUPP)
> > +                             ret = BLK_STS_NOTSUPP;
> > +                     else
> > +                             ret = BLK_STS_IOERR;
> > +             }
>
> Please do not nest if-conditions if that is not necessary. I think the
> above code can be written more clearly as follows:
>
> if (cmd->ret == -ENOTSUPP)
>         ret = BLK_STS_NOTSUPP;
> else if (cmd->ret < 0)
>         ret = BLK_STS_IOERR;
>

Thanks for taking a look Bart. Will fix.
-Evan