linux-kernel - Re: [PATCH 0/2] KVM: SVM: move the SEV command handling into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190201182040.GD12454@linux.intel.com>
Date:   Fri, 1 Feb 2019 10:20:40 -0800
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     "Singh, Brijesh" <brijesh.singh@....com>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>, Borislav Petkov <bp@...en8.de>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Joerg Roedel <joro@...tes.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>
Subject: Re: [PATCH 0/2] KVM: SVM: move the SEV command handling into a
 separate file

On Fri, Feb 01, 2019 at 04:47:12PM +0000, Singh, Brijesh wrote:
> svm.c is pretty huge, before we add more SEV specific commands (e.g SEV-ES,
> SEV-Migration etc) lets move the SEV command handling into a separate file.
> There is no logical changes in this series.

Any reason not to create arch/x86/kvm/svm/ before introducing sev.c? 

> The patch is based on motivation from this thread:
> https://marc.info/?l=linux-kernel&m=153910240507399&w=2
> 
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: "Radim Krčmář" <rkrcmar@...hat.com>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Tom Lendacky <Thomas.Lendacky@....com>
> 
> Brijesh Singh (2):
>   KVM: SVM: move common struct definitions to header file
>   KVM: SVM: move the SEV specific function in a separate file
> 
>  arch/x86/include/asm/svm.h |  155 +++++
>  arch/x86/kvm/Makefile      |    2 +
>  arch/x86/kvm/sev.c         | 1076 +++++++++++++++++++++++++++++++
>  arch/x86/kvm/sev.h         |   40 ++
>  arch/x86/kvm/svm.c         | 1234 +-----------------------------------
>  5 files changed, 1296 insertions(+), 1211 deletions(-)
>  create mode 100644 arch/x86/kvm/sev.c
>  create mode 100644 arch/x86/kvm/sev.h
> 
> -- 
> 2.17.1
>